diff options
author | mathieui <mathieui@mathieui.net> | 2016-08-21 15:27:53 +0200 |
---|---|---|
committer | mathieui <mathieui@mathieui.net> | 2016-08-21 15:39:30 +0200 |
commit | 84e59b05ff0a17178da9ecdb6c5d084e48b42763 (patch) | |
tree | 224948d7c3d49a0005bff9390260357b3ec9c60e /plugins/ping.py | |
parent | 6c270b363ac018dfd4d66b23af95efcc35610da0 (diff) | |
download | poezio-84e59b05ff0a17178da9ecdb6c5d084e48b42763.tar.gz poezio-84e59b05ff0a17178da9ecdb6c5d084e48b42763.tar.bz2 poezio-84e59b05ff0a17178da9ecdb6c5d084e48b42763.tar.xz poezio-84e59b05ff0a17178da9ecdb6c5d084e48b42763.zip |
Don’t call input completion() functions inside completion methods
Use a placeholder object that can run it afterwards, so that we don’t
have side effects inside those functions.
Diffstat (limited to 'plugins/ping.py')
-rw-r--r-- | plugins/ping.py | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/plugins/ping.py b/plugins/ping.py index 066ad1f6..533053b7 100644 --- a/plugins/ping.py +++ b/plugins/ping.py @@ -27,6 +27,7 @@ from poezio.plugin import BasePlugin from poezio.roster import roster from poezio.common import safeJID from poezio.contact import Contact, Resource +from poezio.core.structs import Completion from poezio import tabs import time @@ -74,7 +75,7 @@ class Plugin(BasePlugin): users = [user.nick for user in self.api.current_tab().users] l = self.resources() users.extend(l) - return the_input.auto_completion(users, '', quotify=False) + return Completion(the_input.auto_completion, users, '', quotify=False) @command_args_parser.raw def command_private_ping(self, arg): @@ -115,5 +116,5 @@ class Plugin(BasePlugin): return l def completion_ping(self, the_input): - return the_input.auto_completion(self.resources(), '', quotify=False) + return Completion(the_input.auto_completion, self.resources(), '', quotify=False) |