From 84e59b05ff0a17178da9ecdb6c5d084e48b42763 Mon Sep 17 00:00:00 2001 From: mathieui Date: Sun, 21 Aug 2016 15:27:53 +0200 Subject: =?UTF-8?q?Don=E2=80=99t=20call=20input=20completion()=20functions?= =?UTF-8?q?=20inside=20completion=20methods?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Use a placeholder object that can run it afterwards, so that we don’t have side effects inside those functions. --- plugins/ping.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'plugins/ping.py') diff --git a/plugins/ping.py b/plugins/ping.py index 066ad1f6..533053b7 100644 --- a/plugins/ping.py +++ b/plugins/ping.py @@ -27,6 +27,7 @@ from poezio.plugin import BasePlugin from poezio.roster import roster from poezio.common import safeJID from poezio.contact import Contact, Resource +from poezio.core.structs import Completion from poezio import tabs import time @@ -74,7 +75,7 @@ class Plugin(BasePlugin): users = [user.nick for user in self.api.current_tab().users] l = self.resources() users.extend(l) - return the_input.auto_completion(users, '', quotify=False) + return Completion(the_input.auto_completion, users, '', quotify=False) @command_args_parser.raw def command_private_ping(self, arg): @@ -115,5 +116,5 @@ class Plugin(BasePlugin): return l def completion_ping(self, the_input): - return the_input.auto_completion(self.resources(), '', quotify=False) + return Completion(the_input.auto_completion, self.resources(), '', quotify=False) -- cgit v1.2.3