diff options
| author | Florent Le Coz <louiz@louiz.org> | 2012-10-22 17:14:21 +0200 |
|---|---|---|
| committer | Florent Le Coz <louiz@louiz.org> | 2012-10-22 17:14:21 +0200 |
| commit | a536c1dc4f4c28da96a64a6c91e6ed5061e3c077 (patch) | |
| tree | f112c641b8ad7381d7e0831990ce47beb20a770b /plugins/link.py | |
| parent | 36c02ef0588ce3e10815c40dea26c89ec4cc04f3 (diff) | |
| download | poezio-a536c1dc4f4c28da96a64a6c91e6ed5061e3c077.tar.gz poezio-a536c1dc4f4c28da96a64a6c91e6ed5061e3c077.tar.bz2 poezio-a536c1dc4f4c28da96a64a6c91e6ed5061e3c077.tar.xz poezio-a536c1dc4f4c28da96a64a6c91e6ed5061e3c077.zip | |
Make the Executor class reliable.
Plugins do not need to escape the command arguments or remove the line
breaks and care about how the will get parsed anymore, they just need to
pass a list of args.
Do not spawn an additional shell, for more clarity, simplicity and possibly
security.
Diffstat (limited to 'plugins/link.py')
| -rw-r--r-- | plugins/link.py | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/plugins/link.py b/plugins/link.py index 8d757be6..427d718a 100644 --- a/plugins/link.py +++ b/plugins/link.py @@ -7,7 +7,6 @@ from plugin import BasePlugin from xhtml import clean_text import common import tabs -import pipes url_pattern = re.compile(r'\b(http[s]?://(?:\S+))\b', re.I|re.U) @@ -42,8 +41,7 @@ class Plugin(BasePlugin): nb = 1 link = self.find_link(nb) if link: - link = pipes.quote(link) - self.core.exec_command("%s %s" % (self.config.get('browser', 'firefox'), link)) + self.core.exec_command([self.config.get('browser', 'firefox'), link]) else: self.core.information('No URL found.', 'Warning') |