From 4598031dd2493a85824d5d9f7488703f5d2d0a14 Mon Sep 17 00:00:00 2001
From: Lance Stout <lancestout@gmail.com>
Date: Mon, 22 Oct 2012 19:22:27 -0700
Subject: Respond to probes when the subscription is 'from', not 'to'.

---
 sleekxmpp/roster/item.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'sleekxmpp')

diff --git a/sleekxmpp/roster/item.py b/sleekxmpp/roster/item.py
index 6e9c0d01..ae194e0a 100644
--- a/sleekxmpp/roster/item.py
+++ b/sleekxmpp/roster/item.py
@@ -479,11 +479,11 @@ class RosterItem(object):
             self.xmpp.event('roster_subscription_removed', presence)
 
     def handle_probe(self, presence):
-        if self['to']:
+        if self['from']:
             self.send_last_presence()
         if self['pending_out']:
             self.subscribe()
-        if not self['to']:
+        if not self['from']:
             self._unsubscribed()
 
     def reset(self):
-- 
cgit v1.2.3


From c5046b9c91a77488424c1f77407a2875a9fea45a Mon Sep 17 00:00:00 2001
From: Lance Stout <lancestout@gmail.com>
Date: Mon, 22 Oct 2012 20:09:35 -0700
Subject: Fix JID cache (wrong in-progress version comitted earlier)

---
 sleekxmpp/jid.py | 51 +++++++++++++++++++++++++--------------------------
 1 file changed, 25 insertions(+), 26 deletions(-)

(limited to 'sleekxmpp')

diff --git a/sleekxmpp/jid.py b/sleekxmpp/jid.py
index 007bebac..eac51dad 100644
--- a/sleekxmpp/jid.py
+++ b/sleekxmpp/jid.py
@@ -421,33 +421,32 @@ class JID(object):
         if jid is None or jid == '':
             jid = ''
 
-        if jid in JID_CACHE:
-            self._jid = JID_CACHE[jid]
+        if not jid:
+            jid = (None, None, None)
+        elif jid in JID_CACHE:
+            jid = JID_CACHE[jid]
+        elif not isinstance(jid, JID):
+            jid = _parse_jid(jid)
         else:
-            if not jid:
-                jid = (None, None, None)
-            elif not isinstance(jid, JID):
-                jid = _parse_jid(jid)
-            else:
-                jid = jid._jid
-
-            local, domain, resource = jid
-
-            local = kwargs.get('local', local)
-            domain = kwargs.get('domain', domain)
-            resource = kwargs.get('resource', resource)
-
-            if 'local' in kwargs:
-                local = _escape_node(local)
-            if 'domain' in kwargs:
-                domain = _validate_domain(domain)
-            if 'resource' in kwargs:
-                resource = _validate_resource(resource)
-
-            self._jid = (local, domain, resource)
-            JID_CACHE[_format_jid(*self._jid)] = self._jid
-            if len(JID_CACHE) > JID_CACHE_MAX_SIZE:
-                JID_CACHE.popitem(False)
+            jid = jid._jid
+
+        local, domain, resource = jid
+
+        local = kwargs.get('local', local)
+        domain = kwargs.get('domain', domain)
+        resource = kwargs.get('resource', resource)
+
+        if 'local' in kwargs:
+            local = _escape_node(local)
+        if 'domain' in kwargs:
+            domain = _validate_domain(domain)
+        if 'resource' in kwargs:
+            resource = _validate_resource(resource)
+
+        self._jid = (local, domain, resource)
+        JID_CACHE[_format_jid(*self._jid)] = self._jid
+        if len(JID_CACHE) > JID_CACHE_MAX_SIZE:
+            JID_CACHE.popitem(False)
 
     def unescape(self):
         """Return an unescaped JID object.
-- 
cgit v1.2.3