From 335dc2927bf874aa3ee3d4154257040b3b59db1a Mon Sep 17 00:00:00 2001 From: Lance Stout Date: Sat, 8 Oct 2011 17:31:30 -0400 Subject: Break reference cycle to fix potential memory leaks for callback handlers. --- sleekxmpp/xmlstream/handler/base.py | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'sleekxmpp/xmlstream/handler/base.py') diff --git a/sleekxmpp/xmlstream/handler/base.py b/sleekxmpp/xmlstream/handler/base.py index 6ec9b6a3..7f05c757 100644 --- a/sleekxmpp/xmlstream/handler/base.py +++ b/sleekxmpp/xmlstream/handler/base.py @@ -6,6 +6,8 @@ See the file LICENSE for copying permission. """ +import weakref + class BaseHandler(object): @@ -43,7 +45,10 @@ class BaseHandler(object): stream -- The XMLStream instance the handler should monitor. """ self.name = name - self.stream = stream + if stream is not None: + self.stream = weakref.ref(stream) + else: + self.stream = None self._destroy = False self._payload = None self._matcher = matcher -- cgit v1.2.3