From deb52ad3502a94f91ef5400bf5b7605b8e151f50 Mon Sep 17 00:00:00 2001 From: Vijay Pandurangan Date: Sun, 20 Nov 2011 03:30:44 +0800 Subject: This change stops sleekxmpp from spending huge amounts of time unnecessarily computing logging data that may never be used. This is a HUGE performance improvement; in some of my test runs, unnecessary string creation was accounting for > 60% of all CPU time. Note that using % in a string will _always_ perform the sting substitutions, because the strings are constructed before the function is called. So log.debug('%s' % expensiveoperation()) will take about the same CPU time whether or not the logging level is DEBUG or INFO. if you use , no substitutions are performed unless the string is actually logged --- conn_tests/testpubsub.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'conn_tests/testpubsub.py') diff --git a/conn_tests/testpubsub.py b/conn_tests/testpubsub.py index 3aa7200e..0f46524e 100755 --- a/conn_tests/testpubsub.py +++ b/conn_tests/testpubsub.py @@ -329,11 +329,11 @@ if __name__ == '__main__': logging.basicConfig(level=opts.loglevel, format='%(levelname)-8s %(message)s') #load xml config - logging.info("Loading config file: %s" % opts.configfile) + logging.info("Loading config file: %s" , opts.configfile) config = ET.parse(os.path.expanduser(opts.configfile)).find('auth') #init - logging.info("Logging in as %s" % config.attrib['jid']) + logging.info("Logging in as %s" , config.attrib['jid']) plugin_config = {} -- cgit v1.2.3