From deb52ad3502a94f91ef5400bf5b7605b8e151f50 Mon Sep 17 00:00:00 2001 From: Vijay Pandurangan Date: Sun, 20 Nov 2011 03:30:44 +0800 Subject: This change stops sleekxmpp from spending huge amounts of time unnecessarily computing logging data that may never be used. This is a HUGE performance improvement; in some of my test runs, unnecessary string creation was accounting for > 60% of all CPU time. Note that using % in a string will _always_ perform the sting substitutions, because the strings are constructed before the function is called. So log.debug('%s' % expensiveoperation()) will take about the same CPU time whether or not the logging level is DEBUG or INFO. if you use , no substitutions are performed unless the string is actually logged --- conn_tests/test_pubsubserver.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'conn_tests/test_pubsubserver.py') diff --git a/conn_tests/test_pubsubserver.py b/conn_tests/test_pubsubserver.py index 15635b4b..aae77dd3 100644 --- a/conn_tests/test_pubsubserver.py +++ b/conn_tests/test_pubsubserver.py @@ -186,14 +186,14 @@ if __name__ == '__main__': logging.basicConfig(level=opts.loglevel, format='%(levelname)-8s %(message)s') #load xml config - logging.info("Loading config file: %s" % opts.configfile) + logging.info("Loading config file: %s" , opts.configfile) config = configparser.RawConfigParser() config.read(opts.configfile) #init - logging.info("Account 1 is %s" % config.get('account1', 'jid')) + logging.info("Account 1 is %s" , config.get('account1', 'jid')) xmpp1 = TestClient(config.get('account1','jid'), config.get('account1','pass')) - logging.info("Account 2 is %s" % config.get('account2', 'jid')) + logging.info("Account 2 is %s" , config.get('account2', 'jid')) xmpp2 = TestClient(config.get('account2','jid'), config.get('account2','pass')) xmpp1.registerPlugin('xep_0004') -- cgit v1.2.3