From 4027927c6e2de70d334902e9b6c7b615404f57b4 Mon Sep 17 00:00:00 2001 From: mathieui Date: Wed, 4 Feb 2015 16:49:39 +0100 Subject: =?UTF-8?q?Don=E2=80=99t=20set=20the=20msg['from']=20and=20msg['id?= =?UTF-8?q?']=20in=20receipt.ack()?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit setting msg['id'] is wrong, and setting msg['from'] might lead to echoing back wrong input. --- slixmpp/plugins/xep_0184/receipt.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/slixmpp/plugins/xep_0184/receipt.py b/slixmpp/plugins/xep_0184/receipt.py index 9ca138b9..2c3555dc 100644 --- a/slixmpp/plugins/xep_0184/receipt.py +++ b/slixmpp/plugins/xep_0184/receipt.py @@ -67,9 +67,7 @@ class XEP_0184(BasePlugin): """ ack = self.xmpp.Message() ack['to'] = msg['from'] - ack['from'] = msg['to'] ack['receipt'] = msg['id'] - ack['id'] = msg['id'] ack.send() def _handle_receipt_received(self, msg): -- cgit v1.2.3