summaryrefslogtreecommitdiff
path: root/sleekxmpp/xmlstream
diff options
context:
space:
mode:
authorNathan Fritz <nathan@andyet.net>2010-05-12 13:45:36 -0700
committerNathan Fritz <nathan@andyet.net>2010-05-12 13:45:36 -0700
commit223507f36f6dd4c0d4a0733a524fd529231b010b (patch)
treed8e5de1732e9651299a27c9300e464221066ec65 /sleekxmpp/xmlstream
parent8515cef11734613267b1b31f543bca620beac864 (diff)
downloadslixmpp-223507f36f6dd4c0d4a0733a524fd529231b010b.tar.gz
slixmpp-223507f36f6dd4c0d4a0733a524fd529231b010b.tar.bz2
slixmpp-223507f36f6dd4c0d4a0733a524fd529231b010b.tar.xz
slixmpp-223507f36f6dd4c0d4a0733a524fd529231b010b.zip
fixed a rather large memory leak
Diffstat (limited to 'sleekxmpp/xmlstream')
-rw-r--r--sleekxmpp/xmlstream/stanzabase.py14
1 files changed, 9 insertions, 5 deletions
diff --git a/sleekxmpp/xmlstream/stanzabase.py b/sleekxmpp/xmlstream/stanzabase.py
index 57c727a3..018e81c3 100644
--- a/sleekxmpp/xmlstream/stanzabase.py
+++ b/sleekxmpp/xmlstream/stanzabase.py
@@ -9,6 +9,7 @@ from xml.etree import cElementTree as ET
import logging
import traceback
import sys
+import weakref
if sys.version_info < (3,0):
from . import tostring26 as tostring
@@ -51,7 +52,10 @@ class ElementBase(tostring.ToString):
subitem = None
def __init__(self, xml=None, parent=None):
- self.parent = parent
+ if parent is None:
+ self.parent = None
+ else:
+ self.parent = weakref.ref(parent)
self.xml = xml
self.plugins = {}
self.iterables = []
@@ -158,7 +162,7 @@ class ElementBase(tostring.ToString):
else:
self.xml.append(new)
if self.parent is not None:
- self.parent.xml.append(self.xml)
+ self.parent().xml.append(self.xml)
return True #had to generate XML
else:
return False
@@ -302,9 +306,9 @@ class ElementBase(tostring.ToString):
self.xml.append(xml)
return self
- def __del__(self):
- if self.parent is not None:
- self.parent.xml.remove(self.xml)
+ #def __del__(self): #prevents garbage collection of reference cycle
+ # if self.parent is not None:
+ # self.parent.xml.remove(self.xml)
class StanzaBase(ElementBase):
name = 'stanza'