diff options
| author | Nathan Fritz <nathan@andyet.net> | 2010-05-13 04:45:36 +0800 |
|---|---|---|
| committer | Tom Nichols <tmnichols@gmail.com> | 2010-05-14 01:47:19 +0800 |
| commit | 4c410dd48aefc69682c30f28e830e5dee62a04ab (patch) | |
| tree | af3fd36f92a9fbf4660b5264137680070a5da893 /sleekxmpp/xmlstream/stanzabase.py | |
| parent | e0c32b6d9bc357e79db04ea3126a614e038af928 (diff) | |
| download | slixmpp-4c410dd48aefc69682c30f28e830e5dee62a04ab.tar.gz slixmpp-4c410dd48aefc69682c30f28e830e5dee62a04ab.tar.bz2 slixmpp-4c410dd48aefc69682c30f28e830e5dee62a04ab.tar.xz slixmpp-4c410dd48aefc69682c30f28e830e5dee62a04ab.zip | |
fixed a rather large memory leak
Diffstat (limited to 'sleekxmpp/xmlstream/stanzabase.py')
| -rw-r--r-- | sleekxmpp/xmlstream/stanzabase.py | 14 |
1 files changed, 9 insertions, 5 deletions
diff --git a/sleekxmpp/xmlstream/stanzabase.py b/sleekxmpp/xmlstream/stanzabase.py index 57c727a3..018e81c3 100644 --- a/sleekxmpp/xmlstream/stanzabase.py +++ b/sleekxmpp/xmlstream/stanzabase.py @@ -9,6 +9,7 @@ from xml.etree import cElementTree as ET import logging import traceback import sys +import weakref if sys.version_info < (3,0): from . import tostring26 as tostring @@ -51,7 +52,10 @@ class ElementBase(tostring.ToString): subitem = None def __init__(self, xml=None, parent=None): - self.parent = parent + if parent is None: + self.parent = None + else: + self.parent = weakref.ref(parent) self.xml = xml self.plugins = {} self.iterables = [] @@ -158,7 +162,7 @@ class ElementBase(tostring.ToString): else: self.xml.append(new) if self.parent is not None: - self.parent.xml.append(self.xml) + self.parent().xml.append(self.xml) return True #had to generate XML else: return False @@ -302,9 +306,9 @@ class ElementBase(tostring.ToString): self.xml.append(xml) return self - def __del__(self): - if self.parent is not None: - self.parent.xml.remove(self.xml) + #def __del__(self): #prevents garbage collection of reference cycle + # if self.parent is not None: + # self.parent.xml.remove(self.xml) class StanzaBase(ElementBase): name = 'stanza' |