diff options
| author | Vijay Pandurangan <vijayp@vijayp.ca> | 2011-11-20 03:30:44 +0800 |
|---|---|---|
| committer | Lance Stout <lancestout@gmail.com> | 2011-11-20 03:39:05 +0800 |
| commit | deb52ad3502a94f91ef5400bf5b7605b8e151f50 (patch) | |
| tree | 879d9e076ed037bf5056514a8e470e7d471f26ca /sleekxmpp/plugins/xep_0199/ping.py | |
| parent | 1baf139ca4be0c05a6a845becf18412b213a3c02 (diff) | |
| download | slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.gz slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.bz2 slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.xz slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.zip | |
This change stops sleekxmpp from spending huge amounts of time unnecessarily computing logging data that may never be used. This is a HUGE performance improvement; in some of my test runs, unnecessary string creation was accounting for > 60% of all CPU time.
Note that using % in a string will _always_ perform the sting substitutions, because the strings are constructed before the function is called. So log.debug('%s' % expensiveoperation()) will take about the same CPU time whether or not the logging level is DEBUG or INFO. if you use , no substitutions are performed unless the string is actually logged
Diffstat (limited to 'sleekxmpp/plugins/xep_0199/ping.py')
| -rw-r--r-- | sleekxmpp/plugins/xep_0199/ping.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/sleekxmpp/plugins/xep_0199/ping.py b/sleekxmpp/plugins/xep_0199/ping.py index de7f5688..f8ae4018 100644 --- a/sleekxmpp/plugins/xep_0199/ping.py +++ b/sleekxmpp/plugins/xep_0199/ping.py @@ -118,7 +118,7 @@ class xep_0199(base_plugin): Arguments: iq -- The ping request. """ - log.debug("Pinged by %s" % iq['from']) + log.debug("Pinged by %s" , iq['from']) iq.reply().send() def send_ping(self, jid, timeout=None, errorfalse=False, @@ -141,7 +141,7 @@ class xep_0199(base_plugin): is received. Useful in conjunction with the option block=False. """ - log.debug("Pinging %s" % jid) + log.debug("Pinging %s" , jid) if timeout is None: timeout = self.timeout @@ -167,7 +167,7 @@ class xep_0199(base_plugin): if not block: return None - log.debug("Pong: %s %f" % (jid, delay)) + log.debug("Pong: %s %f" , jid, delay) return delay |