diff options
| author | Vijay Pandurangan <vijayp@vijayp.ca> | 2011-11-20 03:30:44 +0800 |
|---|---|---|
| committer | Lance Stout <lancestout@gmail.com> | 2011-11-20 03:39:05 +0800 |
| commit | deb52ad3502a94f91ef5400bf5b7605b8e151f50 (patch) | |
| tree | 879d9e076ed037bf5056514a8e470e7d471f26ca /sleekxmpp/plugins/xep_0009/rpc.py | |
| parent | 1baf139ca4be0c05a6a845becf18412b213a3c02 (diff) | |
| download | slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.gz slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.bz2 slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.xz slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.zip | |
This change stops sleekxmpp from spending huge amounts of time unnecessarily computing logging data that may never be used. This is a HUGE performance improvement; in some of my test runs, unnecessary string creation was accounting for > 60% of all CPU time.
Note that using % in a string will _always_ perform the sting substitutions, because the strings are constructed before the function is called. So log.debug('%s' % expensiveoperation()) will take about the same CPU time whether or not the logging level is DEBUG or INFO. if you use , no substitutions are performed unless the string is actually logged
Diffstat (limited to 'sleekxmpp/plugins/xep_0009/rpc.py')
| -rw-r--r-- | sleekxmpp/plugins/xep_0009/rpc.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/sleekxmpp/plugins/xep_0009/rpc.py b/sleekxmpp/plugins/xep_0009/rpc.py index fc306d31..7f150511 100644 --- a/sleekxmpp/plugins/xep_0009/rpc.py +++ b/sleekxmpp/plugins/xep_0009/rpc.py @@ -128,22 +128,22 @@ class xep_0009(base.base_plugin): def _handle_method_call(self, iq):
type = iq['type']
if type == 'set':
- log.debug("Incoming Jabber-RPC call from %s" % iq['from'])
+ log.debug("Incoming Jabber-RPC call from %s" , iq['from'])
self.xmpp.event('jabber_rpc_method_call', iq)
else:
if type == 'error' and ['rpc_query'] is None:
self.handle_error(iq)
else:
- log.debug("Incoming Jabber-RPC error from %s" % iq['from'])
+ log.debug("Incoming Jabber-RPC error from %s" , iq['from'])
self.xmpp.event('jabber_rpc_error', iq)
def _handle_method_response(self, iq):
if iq['rpc_query']['method_response']['fault'] is not None:
- log.debug("Incoming Jabber-RPC fault from %s" % iq['from'])
+ log.debug("Incoming Jabber-RPC fault from %s" , iq['from'])
#self._on_jabber_rpc_method_fault(iq)
self.xmpp.event('jabber_rpc_method_fault', iq)
else:
- log.debug("Incoming Jabber-RPC response from %s" % iq['from'])
+ log.debug("Incoming Jabber-RPC response from %s" , iq['from'])
self.xmpp.event('jabber_rpc_method_response', iq)
def _handle_error(self, iq):
|