diff options
| author | Vijay Pandurangan <vijayp@vijayp.ca> | 2011-11-20 03:30:44 +0800 |
|---|---|---|
| committer | Lance Stout <lancestout@gmail.com> | 2011-11-20 03:39:05 +0800 |
| commit | deb52ad3502a94f91ef5400bf5b7605b8e151f50 (patch) | |
| tree | 879d9e076ed037bf5056514a8e470e7d471f26ca /conn_tests | |
| parent | 1baf139ca4be0c05a6a845becf18412b213a3c02 (diff) | |
| download | slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.gz slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.bz2 slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.tar.xz slixmpp-deb52ad3502a94f91ef5400bf5b7605b8e151f50.zip | |
This change stops sleekxmpp from spending huge amounts of time unnecessarily computing logging data that may never be used. This is a HUGE performance improvement; in some of my test runs, unnecessary string creation was accounting for > 60% of all CPU time.
Note that using % in a string will _always_ perform the sting substitutions, because the strings are constructed before the function is called. So log.debug('%s' % expensiveoperation()) will take about the same CPU time whether or not the logging level is DEBUG or INFO. if you use , no substitutions are performed unless the string is actually logged
Diffstat (limited to 'conn_tests')
| -rw-r--r-- | conn_tests/test_pubsubjobs.py | 6 | ||||
| -rw-r--r-- | conn_tests/test_pubsubserver.py | 6 | ||||
| -rwxr-xr-x | conn_tests/testpubsub.py | 4 |
3 files changed, 8 insertions, 8 deletions
diff --git a/conn_tests/test_pubsubjobs.py b/conn_tests/test_pubsubjobs.py index edf22ccc..ec2a2716 100644 --- a/conn_tests/test_pubsubjobs.py +++ b/conn_tests/test_pubsubjobs.py @@ -122,14 +122,14 @@ if __name__ == '__main__': logging.basicConfig(level=opts.loglevel, format='%(levelname)-8s %(message)s') #load xml config - logging.info("Loading config file: %s" % opts.configfile) + logging.info("Loading config file: %s" , opts.configfile) config = configparser.RawConfigParser() config.read(opts.configfile) #init - logging.info("Account 1 is %s" % config.get('account1', 'jid')) + logging.info("Account 1 is %s" , config.get('account1', 'jid')) xmpp1 = TestClient(config.get('account1','jid'), config.get('account1','pass')) - logging.info("Account 2 is %s" % config.get('account2', 'jid')) + logging.info("Account 2 is %s" , config.get('account2', 'jid')) xmpp2 = TestClient(config.get('account2','jid'), config.get('account2','pass')) xmpp1.registerPlugin('xep_0004') diff --git a/conn_tests/test_pubsubserver.py b/conn_tests/test_pubsubserver.py index 15635b4b..aae77dd3 100644 --- a/conn_tests/test_pubsubserver.py +++ b/conn_tests/test_pubsubserver.py @@ -186,14 +186,14 @@ if __name__ == '__main__': logging.basicConfig(level=opts.loglevel, format='%(levelname)-8s %(message)s') #load xml config - logging.info("Loading config file: %s" % opts.configfile) + logging.info("Loading config file: %s" , opts.configfile) config = configparser.RawConfigParser() config.read(opts.configfile) #init - logging.info("Account 1 is %s" % config.get('account1', 'jid')) + logging.info("Account 1 is %s" , config.get('account1', 'jid')) xmpp1 = TestClient(config.get('account1','jid'), config.get('account1','pass')) - logging.info("Account 2 is %s" % config.get('account2', 'jid')) + logging.info("Account 2 is %s" , config.get('account2', 'jid')) xmpp2 = TestClient(config.get('account2','jid'), config.get('account2','pass')) xmpp1.registerPlugin('xep_0004') diff --git a/conn_tests/testpubsub.py b/conn_tests/testpubsub.py index 3aa7200e..0f46524e 100755 --- a/conn_tests/testpubsub.py +++ b/conn_tests/testpubsub.py @@ -329,11 +329,11 @@ if __name__ == '__main__': logging.basicConfig(level=opts.loglevel, format='%(levelname)-8s %(message)s') #load xml config - logging.info("Loading config file: %s" % opts.configfile) + logging.info("Loading config file: %s" , opts.configfile) config = ET.parse(os.path.expanduser(opts.configfile)).find('auth') #init - logging.info("Logging in as %s" % config.attrib['jid']) + logging.info("Logging in as %s" , config.attrib['jid']) plugin_config = {} |