summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJay Farrimond <jay@instaedu.com>2012-07-06 13:50:15 -0700
committerJay Farrimond <jay@instaedu.com>2012-07-06 13:50:15 -0700
commit23931489085391a97ab8b358e9da1c5c8cfb4e94 (patch)
tree1e195f05a6a0735d14f9978fd3b32b4c26d2c1ec
parentb210870f48e03a90a22d02b5ab7a3c0c81190fd7 (diff)
downloadslixmpp-23931489085391a97ab8b358e9da1c5c8cfb4e94.tar.gz
slixmpp-23931489085391a97ab8b358e9da1c5c8cfb4e94.tar.bz2
slixmpp-23931489085391a97ab8b358e9da1c5c8cfb4e94.tar.xz
slixmpp-23931489085391a97ab8b358e9da1c5c8cfb4e94.zip
dereference iq stanza only once for roster processing
-rw-r--r--sleekxmpp/clientxmpp.py5
1 files changed, 3 insertions, 2 deletions
diff --git a/sleekxmpp/clientxmpp.py b/sleekxmpp/clientxmpp.py
index 7f606de7..03070b06 100644
--- a/sleekxmpp/clientxmpp.py
+++ b/sleekxmpp/clientxmpp.py
@@ -270,8 +270,9 @@ class ClientXMPP(BaseXMPP):
roster = self.client_roster
if iq['roster']['ver']:
roster.version = iq['roster']['ver']
- for jid in iq['roster']['items']:
- item = iq['roster']['items'][jid]
+ items = iq['roster']['items']
+ for jid in items:
+ item = items[jid]
roster[jid]['name'] = item['name']
roster[jid]['groups'] = item['groups']
roster[jid]['from'] = item['subscription'] in ['from', 'both']