summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorBrian Beggs <macdiesel@speakeasy.net>2010-05-04 14:03:38 -0400
committerBrian Beggs <macdiesel@speakeasy.net>2010-05-04 14:03:38 -0400
commit70f69c180cb828f0a76b0d9a441c98036cc96fb0 (patch)
treeb068476a248e22e56b0f24c4f635541726a14b99
parentd40e49397bab4836353cff821359063663dcc2b3 (diff)
downloadslixmpp-70f69c180cb828f0a76b0d9a441c98036cc96fb0.tar.gz
slixmpp-70f69c180cb828f0a76b0d9a441c98036cc96fb0.tar.bz2
slixmpp-70f69c180cb828f0a76b0d9a441c98036cc96fb0.tar.xz
slixmpp-70f69c180cb828f0a76b0d9a441c98036cc96fb0.zip
Fixes for disconnection problems detailed in http://github.com/fritzy/SleekXMPP/issues/#issue/20
Fixes to both ClientXMPP & xmlstream. ClientXMPP was not tracking the changes to authenticated and sessionstarted after the client was disconnected. xmlstream had some funkyness with state in the _process method that was cleaned up and hopefully made a little cleaner. Also changed a DNS issue that was occuring that rendered me unable to disconnect. I would recieve the following error upon reconnect. Exception in thread process: Exception in thread process: Traceback (most recent call last): File "/usr/local/lib/python2.6/threading.py", line 532, in __bootstrap_inner self.run() File "/usr/local/lib/python2.6/threading.py", line 484, in run self.__target(*self.__args, **self.__kwargs) File "/home/macdiesel/tmp/workspace/SleekXMPP/sleekxmpp/xmlstream/xmlstream.py", line 202, in _process self.reconnect() File "/home/macdiesel/tmp/workspace/SleekXMPP/sleekxmpp/__init__.py", line 134, in reconnect XMLStream.reconnect(self) File "/home/macdiesel/tmp/workspace/SleekXMPP/sleekxmpp/xmlstream/xmlstream.py", line 289, in reconnect self.connect() File "/home/macdiesel/tmp/workspace/SleekXMPP/sleekxmpp/__init__.py", line 99, in connect answers = dns.resolver.query("_xmpp-client._tcp.%s" % self.server, "SRV") File "/usr/local/lib/python2.6/site-packages/dns/resolver.py", line 732, in query return get_default_resolver().query(qname, rdtype, rdclass, tcp, source) File "/usr/local/lib/python2.6/site-packages/dns/resolver.py", line 617, in query source=source) File "/usr/local/lib/python2.6/site-packages/dns/query.py", line 113, in udp wire = q.to_wire() File "/usr/local/lib/python2.6/site-packages/dns/message.py", line 404, in to_wire r.add_question(rrset.name, rrset.rdtype, rrset.rdclass) File "/usr/local/lib/python2.6/site-packages/dns/renderer.py", line 152, in add_question self.output.write(struct.pack("!HH", rdtype, rdclass)) TypeError: unsupported operand type(s) for &: 'unicode' and 'long' Seems I was getting this error when calling line 99 in ClientXMPP. You can't bit-shift a 1 and a string and this is why this error is coming up. I removed the "SRV" argument and used the default of 1. not sure exactly what this should be so it may need to be fixed back before it's merged back to trunk. The line in question: answers = dns.resolver.query("_xmpp-client._tcp.%s" % self.server, "SRV")
-rw-r--r--.gitignore1
-rw-r--r--sleekxmpp/__init__.py6
-rw-r--r--sleekxmpp/xmlstream/xmlstream.py6
3 files changed, 10 insertions, 3 deletions
diff --git a/.gitignore b/.gitignore
index 0fe2c40e..788de4c7 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,2 +1,3 @@
*.pyc
+.project
build/
diff --git a/sleekxmpp/__init__.py b/sleekxmpp/__init__.py
index 773f7936..e2cfb1b9 100644
--- a/sleekxmpp/__init__.py
+++ b/sleekxmpp/__init__.py
@@ -96,7 +96,7 @@ class ClientXMPP(basexmpp, XMLStream):
else:
logging.debug("Since no address is supplied, attempting SRV lookup.")
try:
- answers = dns.resolver.query("_xmpp-client._tcp.%s" % self.server, "SRV")
+ answers = dns.resolver.query("_xmpp-client._tcp.%s" % self.server)
except dns.resolver.NXDOMAIN:
logging.debug("No appropriate SRV record found. Using JID server name.")
else:
@@ -131,10 +131,14 @@ class ClientXMPP(basexmpp, XMLStream):
def reconnect(self):
logging.info("Reconnecting")
self.event("disconnected")
+ self.authenticated = False
+ self.sessionstarted = False
XMLStream.reconnect(self)
def disconnect(self, init=True, close=False, reconnect=False):
self.event("disconnected")
+ self.authenticated = False
+ self.sessionstarted = False
XMLStream.disconnect(self, reconnect)
def registerFeature(self, mask, pointer, breaker = False):
diff --git a/sleekxmpp/xmlstream/xmlstream.py b/sleekxmpp/xmlstream/xmlstream.py
index 025884b7..13a87a63 100644
--- a/sleekxmpp/xmlstream/xmlstream.py
+++ b/sleekxmpp/xmlstream/xmlstream.py
@@ -199,9 +199,11 @@ class XMLStream(object):
traceback.print_exc()
self.disconnect(reconnect=True)
if self.state['reconnect']:
+ self.state.set('connected', False)
+ self.state.set('processing', False)
self.reconnect()
- self.state.set('processing', False)
- self.eventqueue.put(('quit', None, None))
+ else:
+ self.eventqueue.put(('quit', None, None))
#self.__thread['readXML'] = threading.Thread(name='readXML', target=self.__readXML)
#self.__thread['readXML'].start()
#self.__thread['spawnEvents'] = threading.Thread(name='spawnEvents', target=self.__spawnEvents)