From e5b4f7ab0d2159d938fe0aa42ab7aba7cd7e6fc5 Mon Sep 17 00:00:00 2001 From: mathieui Date: Sat, 26 Jun 2021 14:53:17 +0200 Subject: fix: do not use re.match() on existing Pattern objects this is duplicating effort and going through re._compile once more approximately slows down the log parsing by 15% --- poezio/logger.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/poezio/logger.py b/poezio/logger.py index 429d5328..139b4046 100644 --- a/poezio/logger.py +++ b/poezio/logger.py @@ -82,10 +82,10 @@ def parse_log_line(msg: str, jid: str = '') -> Optional[LogItem]: :param jid: jid (for error logging) :returns: The LogItem or None on error """ - match = re.match(MESSAGE_LOG_RE, msg) + match = MESSAGE_LOG_RE.match(msg) if match: return LogMessage(*match.groups()) - match = re.match(INFO_LOG_RE, msg) + match = INFO_LOG_RE.match(msg) if match: return LogInfo(*match.groups()) log.debug('Error while parsing %s’s logs: “%s”', jid, msg) -- cgit v1.2.3