From 627f751e0c00c0f208e0688698d90a0c186b435b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maxime=20=E2=80=9Cpep=E2=80=9D=20Buquet?= Date: Fri, 9 Oct 2020 15:11:01 +0200 Subject: poezio/user: rework change_color to only log when necessary MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Maxime “pep” Buquet --- poezio/user.py | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/poezio/user.py b/poezio/user.py index 9a14e6b1..1bae612f 100644 --- a/poezio/user.py +++ b/poezio/user.py @@ -83,15 +83,17 @@ class User: self.nick = nick def change_color(self, color_name: Optional[str], deterministic=False): - color = xhtml.colors.get(color_name) - if color is None: - log.error('Unknown color "%s"', color_name) + if color_name is None: if deterministic: self.set_deterministic_color() else: self.color = choice(get_theme().LIST_COLOR_NICKNAMES) else: - self.color = (color, -1) + color = xhtml.colors.get(color_name) + if color is None: + log.error('Unknown color "%s"', color_name) + else: + self.color = (color, -1) def set_last_talked(self, time: datetime): """ -- cgit v1.2.3