summaryrefslogtreecommitdiff
path: root/data
diff options
context:
space:
mode:
authorMaxime “pep” Buquet <pep@bouah.net>2019-06-07 14:12:19 +0200
committerMaxime “pep” Buquet <pep@bouah.net>2019-06-22 03:01:02 +0200
commit833cccb188967948bc786fa6e9385821f8676362 (patch)
treeba99984b58d8f12ea43190137cbfda1bdf52de0e /data
parentd35256ccc9cd205aa72a5599ab25db7cd7263527 (diff)
downloadpoezio-833cccb188967948bc786fa6e9385821f8676362.tar.gz
poezio-833cccb188967948bc786fa6e9385821f8676362.tar.bz2
poezio-833cccb188967948bc786fa6e9385821f8676362.tar.xz
poezio-833cccb188967948bc786fa6e9385821f8676362.zip
Rework priority handling for events
Introduce the concept of priority for event handlers, instead of the position parameter. The new `priority` parameter replacing `position` should be an integer between 0 and 100. It defaults to 50. The previous `position` parameter was only used to insert at a certain position in the list of handlers (for this particular event). No reference of it was kept, which means that it was not possible to ensure an event was called in the position is was supposed to be. I am now using per-event dicts, containing priority buckets (lists) of handlers. I am using OrderedDicts to make it easier to loop through all of the handlers, as insertion happens less often than reading. I was also suggested using bisect with a simple list of tuples (priority, handler) per event, but bisect tries to compare bound methods, which is obviously not possible. Maybe it would be interesting to find a way use this method instead of OrderedDict as that might be less resource consuming. This said, I don't think this part of poezio is a bottleneck at all, so maybe this is just fine as is. Signed-off-by: Maxime “pep” Buquet <pep@bouah.net>
Diffstat (limited to 'data')
0 files changed, 0 insertions, 0 deletions