summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorlouiz@4325f9fc-e183-4c21-96ce-0ab188b42d13 <louiz@4325f9fc-e183-4c21-96ce-0ab188b42d13>2010-12-21 05:43:57 +0000
committerlouiz@4325f9fc-e183-4c21-96ce-0ab188b42d13 <louiz@4325f9fc-e183-4c21-96ce-0ab188b42d13>2010-12-21 05:43:57 +0000
commitac3e0f7099352254cba53d14d896dc05c9c55e6f (patch)
treea61ff207aa07a2a39e1068111bb00904eef503f1
parent1c923fcdcc60a90fd6e2ebf09c5d4464f16995fd (diff)
downloadpoezio-ac3e0f7099352254cba53d14d896dc05c9c55e6f.tar.gz
poezio-ac3e0f7099352254cba53d14d896dc05c9c55e6f.tar.bz2
poezio-ac3e0f7099352254cba53d14d896dc05c9c55e6f.tar.xz
poezio-ac3e0f7099352254cba53d14d896dc05c9c55e6f.zip
datetime.strftime seems (according to cProfile) to be VERY slow. Improve the refresh performances by reducing A LOT the number of call of this method
-rw-r--r--src/tabs.py14
-rw-r--r--src/windows.py31
2 files changed, 38 insertions, 7 deletions
diff --git a/src/tabs.py b/src/tabs.py
index 62647ad0..c9707996 100644
--- a/src/tabs.py
+++ b/src/tabs.py
@@ -980,7 +980,7 @@ class MucListTab(Tab):
self.list_header = windows.ColumnHeaderWin(columns)
self.listview = windows.ListWin(columns)
self.tab_win = windows.GlobalInfoBar()
- self.default_help_message = windows.HelpText("“j”: join room. “i”: information")
+ self.default_help_message = windows.HelpText("“j”: join room.")
self.input = self.default_help_message
self.key_func["KEY_DOWN"] = self.listview.move_cursor_down
self.key_func["KEY_UP"] = self.listview.move_cursor_up
@@ -1065,6 +1065,18 @@ class MucListTab(Tab):
def get_color_state(self):
return self._color_state
+# class SimpleTextTab(Tab):
+# """
+# A very simple tab, with just a text displaying some
+# information or whatever
+# """
+# def __init__(self, core, text):
+# Tab.__init__(self, core)
+# self.text = text
+# self.text_win =
+
+# def resize(self):
+# pass
def diffmatch(search, string):
"""
Use difflib and a loop to check if search_pattern can
diff --git a/src/windows.py b/src/windows.py
index f4524ff1..9d38cd84 100644
--- a/src/windows.py
+++ b/src/windows.py
@@ -470,8 +470,13 @@ class TextWin(Win):
if not first:
nick = None
time = None
- else:
- time = message.time
+ else: # strftime is VERY slow, improve performance
+ # by calling it only one time here, and
+ # not at each refresh
+ time = {'hour': '%s'%(message.time.strftime("%H"),),
+ 'minute': '%s'%(message.time.strftime("%M"),),
+ 'second': '%s'%(message.time.strftime("%S"),),
+ }
l = Line(nick, color,
time,
txt[:limit], message.color,
@@ -589,12 +594,12 @@ class TextWin(Win):
Write the date on the yth line of the window
"""
self.addstr(theme.CHAR_TIME_LEFT, curses.color_pair(theme.COLOR_TIME_LIMITER))
- self.addstr(time.strftime("%H"), curses.color_pair(theme.COLOR_TIME_NUMBERS))
+ self.addstr(time['hour'], curses.color_pair(theme.COLOR_TIME_NUMBERS))
self.addstr(':', curses.color_pair(theme.COLOR_TIME_SEPARATOR))
- self.addstr(time.strftime("%M"), curses.color_pair(theme.COLOR_TIME_NUMBERS))
+ self.addstr(time['minute'], curses.color_pair(theme.COLOR_TIME_NUMBERS))
self.addstr(':', curses.color_pair(theme.COLOR_TIME_SEPARATOR))
- self.addstr(time.strftime('%S'), curses.color_pair(theme.COLOR_TIME_NUMBERS))
- self.addnstr(theme.CHAR_TIME_RIGHT, curses.color_pair(theme.COLOR_TIME_LIMITER))
+ self.addstr(time['second'], curses.color_pair(theme.COLOR_TIME_NUMBERS))
+ self.addstr(theme.CHAR_TIME_RIGHT, curses.color_pair(theme.COLOR_TIME_LIMITER))
self.addstr(' ')
def resize(self, height, width, y, x, stdscr, room=None):
@@ -1425,3 +1430,17 @@ class ColumnHeaderWin(Win):
self.addstr(0, x, txt, curses.color_pair(theme.COLOR_STATUS_UNAVAILABLE))
x += size
self._refresh()
+
+# class SimpleTextWin(Win):
+# def __init__(self, text):
+# self._text = text
+# self.built_lines = []
+
+# def resize(self, height, width, y, x, stdscr):
+# self._resize(height, width, y, x, stdscr)
+# self.rebuild_text()
+
+# def rebuild_text(self):
+
+# def refresh(self):
+# pass