From f76cd93aff1610c9b4c720a73f6d585e8008dfd1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?louiz=E2=80=99?= Date: Mon, 4 May 2020 23:55:39 +0200 Subject: =?UTF-8?q?Fix=20clang=20warnings=20on=20some=20utils=20function.?= =?UTF-8?q?=20It=E2=80=99s=20also=20faster?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/utils/empty_if_fixed_server.hpp | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) (limited to 'src/utils/empty_if_fixed_server.hpp') diff --git a/src/utils/empty_if_fixed_server.hpp b/src/utils/empty_if_fixed_server.hpp index cbb9cea..2422ee4 100644 --- a/src/utils/empty_if_fixed_server.hpp +++ b/src/utils/empty_if_fixed_server.hpp @@ -7,17 +7,11 @@ namespace utils { - inline std::string empty_if_fixed_server(std::string&& str) + inline const std::string& empty_if_fixed_server(const std::string& str) { + static const std::string empty{}; if (!Config::get("fixed_irc_server", "").empty()) - return {}; - return std::move(str); - } - - inline std::string empty_if_fixed_server(const std::string& str) - { - if (!Config::get("fixed_irc_server", "").empty()) - return {}; + return empty; return str; } -- cgit v1.2.3