From d872c2b49214c0a4db40a9e2d860802d9eedc563 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Tue, 15 Nov 2016 00:23:19 +0100
Subject: Support the ident protocol

fix #3211
---
 src/identd/identd_socket.hpp | 44 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 44 insertions(+)
 create mode 100644 src/identd/identd_socket.hpp

(limited to 'src/identd/identd_socket.hpp')

diff --git a/src/identd/identd_socket.hpp b/src/identd/identd_socket.hpp
new file mode 100644
index 0000000..6d6cc1d
--- /dev/null
+++ b/src/identd/identd_socket.hpp
@@ -0,0 +1,44 @@
+#pragma once
+
+#include <network/socket_handler.hpp>
+
+#include <cassert>
+#include <network/tcp_socket_handler.hpp>
+
+#include <logger/logger.hpp>
+#include <xmpp/biboumi_component.hpp>
+
+class XmppComponent;
+class IdentdSocket;
+class IdentdServer;
+template <typename T>
+class TcpSocketServer;
+
+class IdentdSocket: public TCPSocketHandler
+{
+ public:
+  IdentdSocket(std::shared_ptr<Poller> poller, const socket_t socket, TcpSocketServer<IdentdSocket>& server);
+  ~IdentdSocket() = default;
+  std::string generate_answer(const BiboumiComponent& biboumi, uint16_t local, uint16_t remote);
+
+  void parse_in_buffer(const std::size_t size) override final;
+  void on_connection_close(const std::string& message) override final
+  {}
+
+  bool is_connected() const override final
+  {
+    return true;
+  }
+  bool is_connecting() const override final
+  {
+    return false;
+  }
+
+ private:
+  void connect() override
+  { assert(false); }
+  void on_connection_failed(const std::string&) override final
+  { assert(false); }
+
+  IdentdServer& server;
+};
-- 
cgit v1.2.3


From b5a7c66bea8f0bced4bb4ce5c52f17bc30317ec4 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Wed, 16 Nov 2016 20:30:16 +0100
Subject: =?UTF-8?q?fix=20an=20=E2=80=9Cunused=20parameter=E2=80=9D=20warni?=
 =?UTF-8?q?ng?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 src/identd/identd_socket.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/identd/identd_socket.hpp')

diff --git a/src/identd/identd_socket.hpp b/src/identd/identd_socket.hpp
index 6d6cc1d..98077f2 100644
--- a/src/identd/identd_socket.hpp
+++ b/src/identd/identd_socket.hpp
@@ -22,7 +22,7 @@ class IdentdSocket: public TCPSocketHandler
   std::string generate_answer(const BiboumiComponent& biboumi, uint16_t local, uint16_t remote);
 
   void parse_in_buffer(const std::size_t size) override final;
-  void on_connection_close(const std::string& message) override final
+  void on_connection_close(const std::string&) override final
   {}
 
   bool is_connected() const override final
-- 
cgit v1.2.3


From 732f53d798c86558e1e625c22e957243bb2d6467 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Fri, 18 Nov 2016 20:54:41 +0100
Subject: Clean a few more things

---
 src/identd/identd_socket.hpp | 7 -------
 1 file changed, 7 deletions(-)

(limited to 'src/identd/identd_socket.hpp')

diff --git a/src/identd/identd_socket.hpp b/src/identd/identd_socket.hpp
index 98077f2..1c2bd27 100644
--- a/src/identd/identd_socket.hpp
+++ b/src/identd/identd_socket.hpp
@@ -22,8 +22,6 @@ class IdentdSocket: public TCPSocketHandler
   std::string generate_answer(const BiboumiComponent& biboumi, uint16_t local, uint16_t remote);
 
   void parse_in_buffer(const std::size_t size) override final;
-  void on_connection_close(const std::string&) override final
-  {}
 
   bool is_connected() const override final
   {
@@ -35,10 +33,5 @@ class IdentdSocket: public TCPSocketHandler
   }
 
  private:
-  void connect() override
-  { assert(false); }
-  void on_connection_failed(const std::string&) override final
-  { assert(false); }
-
   IdentdServer& server;
 };
-- 
cgit v1.2.3


From f0bc6c83a8eb548d0a3edbf7c16a6922bfd24ba5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Wed, 8 Mar 2017 19:04:15 +0100
Subject: Pass the shared_ptr by reference, to avoid useless copies

---
 src/identd/identd_socket.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'src/identd/identd_socket.hpp')

diff --git a/src/identd/identd_socket.hpp b/src/identd/identd_socket.hpp
index 1c2bd27..10cb797 100644
--- a/src/identd/identd_socket.hpp
+++ b/src/identd/identd_socket.hpp
@@ -17,7 +17,7 @@ class TcpSocketServer;
 class IdentdSocket: public TCPSocketHandler
 {
  public:
-  IdentdSocket(std::shared_ptr<Poller> poller, const socket_t socket, TcpSocketServer<IdentdSocket>& server);
+  IdentdSocket(std::shared_ptr<Poller>& poller, const socket_t socket, TcpSocketServer<IdentdSocket>& server);
   ~IdentdSocket() = default;
   std::string generate_answer(const BiboumiComponent& biboumi, uint16_t local, uint16_t remote);
 
-- 
cgit v1.2.3


From 5402a256d1f0ebbeafa32d250d000cf38fe748fb Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Fri, 7 Apr 2017 18:45:24 +0200
Subject: Apply all the clang-tidy modernize-* fixes

---
 src/identd/identd_socket.hpp | 1 -
 1 file changed, 1 deletion(-)

(limited to 'src/identd/identd_socket.hpp')

diff --git a/src/identd/identd_socket.hpp b/src/identd/identd_socket.hpp
index 10cb797..a386d80 100644
--- a/src/identd/identd_socket.hpp
+++ b/src/identd/identd_socket.hpp
@@ -2,7 +2,6 @@
 
 #include <network/socket_handler.hpp>
 
-#include <cassert>
 #include <network/tcp_socket_handler.hpp>
 
 #include <logger/logger.hpp>
-- 
cgit v1.2.3