From 0c8adc85f7373a85de8b3edc6cac87d5f7389bb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Fri, 11 Nov 2016 02:54:48 +0100
Subject: Move all the connect() logic from TCPSocketHandler into a subclass
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This way, TCPSocketHandler only deal with the message sending/receiving, not
the connect() or anything else.  This will be used for implementing servers
(because when a client is accepted, we don’t need all the connect() and dns
resolution stuff).
---
 louloulibs/network/socket_handler.hpp | 1 +
 1 file changed, 1 insertion(+)

(limited to 'louloulibs/network/socket_handler.hpp')

diff --git a/louloulibs/network/socket_handler.hpp b/louloulibs/network/socket_handler.hpp
index ea79a18..02e3b80 100644
--- a/louloulibs/network/socket_handler.hpp
+++ b/louloulibs/network/socket_handler.hpp
@@ -24,6 +24,7 @@ public:
   virtual void on_send() = 0;
   virtual void connect() = 0;
   virtual bool is_connected() const = 0;
+  virtual bool is_connecting() const = 0;
 
   socket_t get_socket() const
   { return this->socket; }
-- 
cgit v1.2.3


From 42e85d921b0c5e10889d93c24b7ebf355287ee71 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Wed, 16 Nov 2016 23:07:27 +0100
Subject: Remove some useless virtual method from SocketHandler

---
 louloulibs/network/socket_handler.hpp | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

(limited to 'louloulibs/network/socket_handler.hpp')

diff --git a/louloulibs/network/socket_handler.hpp b/louloulibs/network/socket_handler.hpp
index 02e3b80..607a106 100644
--- a/louloulibs/network/socket_handler.hpp
+++ b/louloulibs/network/socket_handler.hpp
@@ -20,11 +20,10 @@ public:
   SocketHandler& operator=(const SocketHandler&) = delete;
   SocketHandler& operator=(SocketHandler&&) = delete;
 
-  virtual void on_recv() = 0;
-  virtual void on_send() = 0;
-  virtual void connect() = 0;
+  virtual void on_recv() {}
+  virtual void on_send() {}
+  virtual void connect() {}
   virtual bool is_connected() const = 0;
-  virtual bool is_connecting() const = 0;
 
   socket_t get_socket() const
   { return this->socket; }
-- 
cgit v1.2.3


From f0bc6c83a8eb548d0a3edbf7c16a6922bfd24ba5 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Wed, 8 Mar 2017 19:04:15 +0100
Subject: Pass the shared_ptr by reference, to avoid useless copies

---
 louloulibs/network/socket_handler.hpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

(limited to 'louloulibs/network/socket_handler.hpp')

diff --git a/louloulibs/network/socket_handler.hpp b/louloulibs/network/socket_handler.hpp
index 607a106..6a7220e 100644
--- a/louloulibs/network/socket_handler.hpp
+++ b/louloulibs/network/socket_handler.hpp
@@ -10,7 +10,7 @@ using socket_t = int;
 class SocketHandler
 {
 public:
-  explicit SocketHandler(std::shared_ptr<Poller> poller, const socket_t socket):
+  explicit SocketHandler(std::shared_ptr<Poller>& poller, const socket_t socket):
     poller(poller),
     socket(socket)
   {}
-- 
cgit v1.2.3


From 0ab40dc1ab4e689921da54080b135e1d22b1c586 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?louiz=E2=80=99?= <louiz@louiz.org>
Date: Tue, 14 Mar 2017 21:45:23 +0100
Subject: Refactoring louloulibs and cmake

Use OBJECT libraries
Remove the louloulibs directory
Write FOUND variables in the cache
---
 louloulibs/network/socket_handler.hpp | 42 -----------------------------------
 1 file changed, 42 deletions(-)
 delete mode 100644 louloulibs/network/socket_handler.hpp

(limited to 'louloulibs/network/socket_handler.hpp')

diff --git a/louloulibs/network/socket_handler.hpp b/louloulibs/network/socket_handler.hpp
deleted file mode 100644
index 6a7220e..0000000
--- a/louloulibs/network/socket_handler.hpp
+++ /dev/null
@@ -1,42 +0,0 @@
-#pragma once
-
-#include <louloulibs.h>
-#include <memory>
-
-class Poller;
-
-using socket_t = int;
-
-class SocketHandler
-{
-public:
-  explicit SocketHandler(std::shared_ptr<Poller>& poller, const socket_t socket):
-    poller(poller),
-    socket(socket)
-  {}
-  virtual ~SocketHandler() = default;
-  SocketHandler(const SocketHandler&) = delete;
-  SocketHandler(SocketHandler&&) = delete;
-  SocketHandler& operator=(const SocketHandler&) = delete;
-  SocketHandler& operator=(SocketHandler&&) = delete;
-
-  virtual void on_recv() {}
-  virtual void on_send() {}
-  virtual void connect() {}
-  virtual bool is_connected() const = 0;
-
-  socket_t get_socket() const
-  { return this->socket; }
-
-protected:
-  /**
-   * A pointer to the poller that manages us, because we need to communicate
-   * with it.
-   */
-  std::shared_ptr<Poller> poller;
-  /**
-   * The handled socket.
-   */
-  socket_t socket;
-};
-
-- 
cgit v1.2.3