summaryrefslogtreecommitdiff
path: root/louloulibs/xmpp/adhoc_commands_handler.cpp
diff options
context:
space:
mode:
authorlouiz’ <louiz@louiz.org>2017-01-06 23:45:26 +0100
committerlouiz’ <louiz@louiz.org>2017-01-06 23:45:26 +0100
commite31ff3e9e94d943d4f307eb6ab8cee7fbd11b565 (patch)
tree42666bddcfcf827426d3086f6f8e71143a059eb4 /louloulibs/xmpp/adhoc_commands_handler.cpp
parent6bf9cedbeb30740c267ea283058c93ed63648fc9 (diff)
downloadbiboumi-e31ff3e9e94d943d4f307eb6ab8cee7fbd11b565.tar.gz
biboumi-e31ff3e9e94d943d4f307eb6ab8cee7fbd11b565.tar.bz2
biboumi-e31ff3e9e94d943d4f307eb6ab8cee7fbd11b565.tar.xz
biboumi-e31ff3e9e94d943d4f307eb6ab8cee7fbd11b565.zip
Fix some issues found by sonar cube
Diffstat (limited to 'louloulibs/xmpp/adhoc_commands_handler.cpp')
-rw-r--r--louloulibs/xmpp/adhoc_commands_handler.cpp9
1 files changed, 2 insertions, 7 deletions
diff --git a/louloulibs/xmpp/adhoc_commands_handler.cpp b/louloulibs/xmpp/adhoc_commands_handler.cpp
index d3ede2d..040d0ff 100644
--- a/louloulibs/xmpp/adhoc_commands_handler.cpp
+++ b/louloulibs/xmpp/adhoc_commands_handler.cpp
@@ -62,13 +62,8 @@ XmlNode AdhocCommandsHandler::handle_request(const std::string& executor_jid, co
"adhocsession"s + sessionid + executor_jid));
}
auto session_it = this->sessions.find(std::make_pair(sessionid, executor_jid));
- if (session_it == this->sessions.end())
- {
- XmlSubNode error(command_node, ADHOC_NS":error");
- error["type"] = "modify";
- XmlSubNode condition(error, STANZA_NS":bad-request");
- }
- else if (action == "execute" || action == "next" || action == "complete")
+ if ((session_it != this->sessions.end()) &&
+ (action == "execute" || action == "next" || action == "complete"))
{
// execute the step
AdhocSession& session = session_it->second;