diff options
author | louiz’ <louiz@louiz.org> | 2016-07-28 10:34:01 +0200 |
---|---|---|
committer | louiz’ <louiz@louiz.org> | 2016-07-28 10:34:01 +0200 |
commit | 11a1c0cc99af9629302184fac2b7adf3ac48516b (patch) | |
tree | 6d85e7ca57a110eff3678e8e37626f2052d6fc02 /louloulibs/network/dns_socket_handler.hpp | |
parent | de0eff6e944db11ae3552e0cd2c191997eebaa2f (diff) | |
download | biboumi-11a1c0cc99af9629302184fac2b7adf3ac48516b.tar.gz biboumi-11a1c0cc99af9629302184fac2b7adf3ac48516b.tar.bz2 biboumi-11a1c0cc99af9629302184fac2b7adf3ac48516b.tar.xz biboumi-11a1c0cc99af9629302184fac2b7adf3ac48516b.zip |
Always remove all the DNS sockets on an c-ares event
Because c-ares may close one of its socket, even if it’s not the one that
has the event. Otherwise we may not know when a socket has been removed from
our poller (automatically, when close()ed) and this leads to bugs.
Diffstat (limited to 'louloulibs/network/dns_socket_handler.hpp')
-rw-r--r-- | louloulibs/network/dns_socket_handler.hpp | 6 |
1 files changed, 5 insertions, 1 deletions
diff --git a/louloulibs/network/dns_socket_handler.hpp b/louloulibs/network/dns_socket_handler.hpp index dba2f26..0570196 100644 --- a/louloulibs/network/dns_socket_handler.hpp +++ b/louloulibs/network/dns_socket_handler.hpp @@ -13,10 +13,12 @@ * (Poller reported it to be writable or readeable) */ +class DNSHandler; + class DNSSocketHandler: public SocketHandler { public: - explicit DNSSocketHandler(std::shared_ptr<Poller> poller, const socket_t socket); + explicit DNSSocketHandler(std::shared_ptr<Poller> poller, DNSHandler& handler, const socket_t socket); ~DNSSocketHandler() = default; DNSSocketHandler(const DNSSocketHandler&) = delete; DNSSocketHandler(DNSSocketHandler&&) = delete; @@ -38,8 +40,10 @@ public: * Always true, see the comment for connect() */ bool is_connected() const override final; + void remove_from_poller(); private: + DNSHandler& handler; }; #endif // CARES_FOUND |