diff options
| author | Florent Le Coz <louiz@louiz.org> | 2015-10-26 20:09:39 +0100 |
|---|---|---|
| committer | Florent Le Coz <louiz@louiz.org> | 2015-10-26 20:09:39 +0100 |
| commit | 142516a69bb000ce80cbb6509d1f407438a94663 (patch) | |
| tree | a2acfe00953a86a036f0bc81f221bbe8e557977f | |
| parent | 0fcba76c793e7c0b1ccc09eaa85016caa11ca3f2 (diff) | |
| download | biboumi-142516a69bb000ce80cbb6509d1f407438a94663.tar.gz biboumi-142516a69bb000ce80cbb6509d1f407438a94663.tar.bz2 biboumi-142516a69bb000ce80cbb6509d1f407438a94663.tar.xz biboumi-142516a69bb000ce80cbb6509d1f407438a94663.zip | |
Fix some trivial issues reported by cppcheck
| -rw-r--r-- | louloulibs/network/tcp_socket_handler.cpp | 2 | ||||
| -rw-r--r-- | src/irc/irc_client.cpp | 1 | ||||
| -rw-r--r-- | src/xmpp/biboumi_component.cpp | 2 | ||||
| -rw-r--r-- | src/xmpp/biboumi_component.hpp | 2 |
4 files changed, 3 insertions, 4 deletions
diff --git a/louloulibs/network/tcp_socket_handler.cpp b/louloulibs/network/tcp_socket_handler.cpp index 72abdcc..f2a2466 100644 --- a/louloulibs/network/tcp_socket_handler.cpp +++ b/louloulibs/network/tcp_socket_handler.cpp @@ -247,7 +247,7 @@ void TCPSocketHandler::on_send() struct msghdr msg{nullptr, 0, msg_iov, 0, nullptr, 0, 0}; - for (std::string& s: this->out_buf) + for (const std::string& s: this->out_buf) { // unconsting the content of s is ok, sendmsg will never modify it msg_iov[msg.msg_iovlen].iov_base = const_cast<char*>(s.data()); diff --git a/src/irc/irc_client.cpp b/src/irc/irc_client.cpp index 0289d72..8f92f9b 100644 --- a/src/irc/irc_client.cpp +++ b/src/irc/irc_client.cpp @@ -888,7 +888,6 @@ void IrcClient::on_unknown_message(const IrcMessage& message) if (message.arguments.size() < 2) return ; std::string from = message.prefix; - const std::string to = message.arguments[0]; std::stringstream ss; for (auto it = message.arguments.begin() + 1; it != message.arguments.end(); ++it) { diff --git a/src/xmpp/biboumi_component.cpp b/src/xmpp/biboumi_component.cpp index 920a2a3..10dce57 100644 --- a/src/xmpp/biboumi_component.cpp +++ b/src/xmpp/biboumi_component.cpp @@ -579,7 +579,7 @@ void BiboumiComponent::send_ping_request(const std::string& from, } void BiboumiComponent::send_iq_room_list_result(const std::string& id, - const std::string to_jid, + const std::string& to_jid, const std::string& from, const std::vector<ListElement>& rooms_list) { diff --git a/src/xmpp/biboumi_component.hpp b/src/xmpp/biboumi_component.hpp index b8fca39..69eebdc 100644 --- a/src/xmpp/biboumi_component.hpp +++ b/src/xmpp/biboumi_component.hpp @@ -66,7 +66,7 @@ public: /** * Send the channels list in one big stanza */ - void send_iq_room_list_result(const std::string& id, const std::string to_jid, + void send_iq_room_list_result(const std::string& id, const std::string& to_jid, const std::string& from, const std::vector<ListElement>& rooms_list); /** |