summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorlouiz’ <louiz@louiz.org>2017-04-07 18:53:12 +0200
committerlouiz’ <louiz@louiz.org>2017-04-07 18:53:12 +0200
commitccb4ee098f0416ab47a46650705dba6495e8bec7 (patch)
treea309d09af17cd0d49a768660232bfaa9df100a57
parent5402a256d1f0ebbeafa32d250d000cf38fe748fb (diff)
downloadbiboumi-ccb4ee098f0416ab47a46650705dba6495e8bec7.tar.gz
biboumi-ccb4ee098f0416ab47a46650705dba6495e8bec7.tar.bz2
biboumi-ccb4ee098f0416ab47a46650705dba6495e8bec7.tar.xz
biboumi-ccb4ee098f0416ab47a46650705dba6495e8bec7.zip
Apply all the clang-tidy misc-* fixes
-rw-r--r--src/irc/iid.cpp2
-rw-r--r--src/irc/irc_client.cpp4
-rw-r--r--src/network/credentials_manager.cpp2
-rw-r--r--src/network/tcp_socket_handler.cpp1
-rw-r--r--src/utils/timed_events.cpp4
5 files changed, 6 insertions, 7 deletions
diff --git a/src/irc/iid.cpp b/src/irc/iid.cpp
index 63c7039..a63a1c3 100644
--- a/src/irc/iid.cpp
+++ b/src/irc/iid.cpp
@@ -9,7 +9,7 @@
constexpr char Iid::separator[];
Iid::Iid(std::string local, std::string server, Iid::Type type):
- type(std::move(type)),
+ type(type),
local(std::move(local)),
server(std::move(server))
{
diff --git a/src/irc/irc_client.cpp b/src/irc/irc_client.cpp
index 710ba15..1d025f2 100644
--- a/src/irc/irc_client.cpp
+++ b/src/irc/irc_client.cpp
@@ -382,7 +382,7 @@ void IrcClient::send_message(IrcMessage&& message)
std::string res;
if (!message.prefix.empty())
res += ":" + std::move(message.prefix) + " ";
- res += std::move(message.command);
+ res += message.command;
for (const std::string& arg: message.arguments)
{
if (arg.find(" ") != std::string::npos ||
@@ -889,7 +889,7 @@ void IrcClient::on_part(const IrcMessage& message)
// channel pointer is now invalid
channel = nullptr;
}
- this->bridge.send_muc_leave(iid, std::move(nick), std::move(txt), self);
+ this->bridge.send_muc_leave(iid, std::move(nick), txt, self);
}
}
diff --git a/src/network/credentials_manager.cpp b/src/network/credentials_manager.cpp
index f9f8c94..0908a2f 100644
--- a/src/network/credentials_manager.cpp
+++ b/src/network/credentials_manager.cpp
@@ -98,7 +98,7 @@ bool BasicCredentialsManager::try_to_open_one_ca_bundle(const std::vector<std::s
// because the certificate is signed by an issuer that was ignored.
try {
Botan::X509_Certificate cert(bundle);
- BasicCredentialsManager::certificate_store.add_certificate(std::move(cert));
+ BasicCredentialsManager::certificate_store.add_certificate(cert);
} catch (const Botan::Decoding_Error& error) {
continue;
}
diff --git a/src/network/tcp_socket_handler.cpp b/src/network/tcp_socket_handler.cpp
index b5e5db1..1bb8bf3 100644
--- a/src/network/tcp_socket_handler.cpp
+++ b/src/network/tcp_socket_handler.cpp
@@ -42,7 +42,6 @@ namespace
using namespace std::string_literals;
using namespace std::chrono_literals;
-namespace ph = std::placeholders;
TCPSocketHandler::TCPSocketHandler(std::shared_ptr<Poller>& poller):
SocketHandler(poller, -1),
diff --git a/src/utils/timed_events.cpp b/src/utils/timed_events.cpp
index e35a659..26ded82 100644
--- a/src/utils/timed_events.cpp
+++ b/src/utils/timed_events.cpp
@@ -3,7 +3,7 @@
TimedEvent::TimedEvent(std::chrono::steady_clock::time_point&& time_point,
std::function<void()> callback, std::string name):
- time_point(std::move(time_point)),
+ time_point(time_point),
callback(std::move(callback)),
repeat(false),
repeat_delay(0),
@@ -16,7 +16,7 @@ TimedEvent::TimedEvent(std::chrono::milliseconds&& duration,
time_point(std::chrono::steady_clock::now() + duration),
callback(std::move(callback)),
repeat(true),
- repeat_delay(std::move(duration)),
+ repeat_delay(duration),
name(std::move(name))
{
}